Ml classifier #1963
Merged
Ml classifier #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Noah Biederbeck <[email protected]>
Co-authored-by: Noah Biederbeck <[email protected]>
Co-authored-by: Noah Biederbeck <[email protected]>
Co-authored-by: Noah Biederbeck <[email protected]>
Co-authored-by: Noah Biederbeck <[email protected]>
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available Co-authored-by: Noah Biederbeck <[email protected]>
Co-authored-by: Noah Biederbeck <[email protected]>
Co-authored-by: Noah Biederbeck <[email protected]>
|
Failing tests should be on ml branch, maybe due to 1a500c8 |
|
Looks good, the test failure is fixed in the ml branch, I am merging this in to be able to update the table quality stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the ctapipe meeting, we implemented the training and applying of the particle classifier including the changes in
ctapipe-process.To avoid the connected design discussions, we added new tools instead of expanding the existing train/apply tools for the energy regressor.
This can be added at a later stage (once we also have disp models).
Unrelated change:
To fix the unit tests, the test for the apply energy regressor tool now uses the dl1 parameters file and the ml config has beed adapted to not use subarray features. This is due to #1961